From f18210c30e67de4bede7c6080d85629f7086676c Mon Sep 17 00:00:00 2001 From: alex Date: Fri, 10 Jul 2026 20:28:47 +0200 Subject: separated commands into their own files TODO: refactor all commands to work like this --- pkg/commands/command-registry.go | 58 ++++++++++++++++++++++++++++++++++++++++ pkg/commands/del.go | 15 +++++++++++ pkg/commands/get.go | 28 +++++++++++++++++++ pkg/commands/set.go | 10 +++++++ 4 files changed, 111 insertions(+) create mode 100644 pkg/commands/command-registry.go create mode 100644 pkg/commands/del.go create mode 100644 pkg/commands/get.go create mode 100644 pkg/commands/set.go (limited to 'pkg/commands') diff --git a/pkg/commands/command-registry.go b/pkg/commands/command-registry.go new file mode 100644 index 0000000..0193da1 --- /dev/null +++ b/pkg/commands/command-registry.go @@ -0,0 +1,58 @@ +package commands + +import ( + "errors" + "redisClone/pkg/core" +) +func SingleKey(args []string) []string { + return []string{args[1]} +} + +func AllSubsequentKeys(args []string) []string { + return args[1:] +} + +func NoKeys(args []string) []string { + return nil +} + +type CommandDef struct{ + MinArgs int + ExtractKeys func(args []string)[]string + Execute func(args []string, getShard func(k string) *core.Shard) interface{} +} + +func DispatchBaseCommand(db core.RedisDB ,commandName string, args []string) interface{} { + cmd, exists := Registry[commandName] + if !exists { + return nil + } + + if len(args) < cmd.MinArgs { + return errors.New("wrong number of arguments") + } + + keys := cmd.ExtractKeys(args) + + db.Lock(keys) + defer db.Unlock(keys) + return cmd.Execute(args, db.GetShard) +} + +var Registry = map[string]CommandDef{ + "GET": { + MinArgs: 2, + ExtractKeys: SingleKey, + Execute: Get, + }, + "SET": { + MinArgs: 3, + ExtractKeys: SingleKey, + Execute: Set, + }, + "DEL": { + MinArgs: 2, + ExtractKeys: AllSubsequentKeys, + Execute: Del, + }, +} \ No newline at end of file diff --git a/pkg/commands/del.go b/pkg/commands/del.go new file mode 100644 index 0000000..bc7d3f9 --- /dev/null +++ b/pkg/commands/del.go @@ -0,0 +1,15 @@ +package commands + +import "redisClone/pkg/core" + +func Del(args []string, getShard func(k string) *core.Shard) interface{} { + count := 0 + for _, key := range args[1:] { + shard := getShard(key) + if _, exists := shard.Data[key]; exists { + delete(shard.Data, key) + count++ + } + } + return count + } \ No newline at end of file diff --git a/pkg/commands/get.go b/pkg/commands/get.go new file mode 100644 index 0000000..9dc2bcd --- /dev/null +++ b/pkg/commands/get.go @@ -0,0 +1,28 @@ +package commands + +import ( + "errors" + "redisClone/pkg/core" + "time" +) + +func Get(args []string, getShard func(k string) *core.Shard) interface{} { + key := args[1] + s := getShard(key) + item, exists := s.Data[key] + if !exists { + return nil + } + + if item.ExpiresAt != nil && time.Now().After(*item.ExpiresAt) { + delete(s.Data, key) + return nil + } + + strValue, ok := item.Value.(string) + if !ok { + err := errors.New("WRONGTYPE Operation against a key holding the wrong kind of value") + return err + } + return strValue + } \ No newline at end of file diff --git a/pkg/commands/set.go b/pkg/commands/set.go new file mode 100644 index 0000000..19175f1 --- /dev/null +++ b/pkg/commands/set.go @@ -0,0 +1,10 @@ +package commands + +import "redisClone/pkg/core" + +func Set(args []string, getShard func(k string) *core.Shard) interface{} { + key := args[1] + item := core.Item{Value: args[2]} + getShard(key).Data[key] = item + return core.SimpleString("OK") + } \ No newline at end of file -- cgit v1.2.3