refactored more commands to work with command registry

3 files changed, 70 insertions, 0 deletions

diff --git a/pkg/commands/command-registry.go b/pkg/commands/command-registry.go
index eaefc65..7db4923 100644
--- a/pkg/commands/command-registry.go
+++ b/pkg/commands/command-registry.go
@@ -75,4 +75,14 @@ var Registry = map[string]CommandDef{
         ExtractKeys: SingleKey,
         Execute: Rename,
     },
+    "RPOP": {
+        MinArgs:     2,
+        ExtractKeys: SingleKey,
+        Execute: Rpop,
+    },
+    "LPOP": {
+        MinArgs:     2,
+        ExtractKeys: SingleKey,
+        Execute: Lpop,
+    },
 }
\ No newline at end of file
diff --git a/pkg/commands/lpop.go b/pkg/commands/lpop.go
new file mode 100644
index 0000000..d1e1ccb
--- /dev/null
+++ b/pkg/commands/lpop.go
@@ -0,0 +1,30 @@
+package commands
+
+import (
+	"errors"
+	"redisClone/pkg/core"
+)
+
+func Lpop(args []string, getShard func(k string) *core.Shard) interface{}{
+		key := args[1]
+		s := getShard(key)
+		item, exists := s.Data[key]
+		if !exists {
+			return nil
+		}
+		typedList, ok := item.Value.([]string)
+		if !ok {
+			return errors.New("WRONGTYPE Operation against a key holding the wrong kind of value")
+		}
+		if len(typedList) == 0 {
+			return nil
+		}
+		newItem := typedList[0]
+		newList := typedList[1:]
+		if len(newList) <= 0 {
+			delete(s.Data, key)
+		} else {
+			s.Data[key] = core.Item{Value: newList}
+		}
+		return newItem
+}
\ No newline at end of file
diff --git a/pkg/commands/rpop.go b/pkg/commands/rpop.go
new file mode 100644
index 0000000..4ef4a1d
--- /dev/null
+++ b/pkg/commands/rpop.go
@@ -0,0 +1,30 @@
+package commands
+
+import (
+	"errors"
+	"redisClone/pkg/core"
+)
+
+func Rpop(args []string, getShard func(k string) *core.Shard) interface{}{
+		key := args[1]
+		s := getShard(key)
+		item, exists := s.Data[key]
+		if !exists {
+			return nil
+		}
+		typedList, ok := item.Value.([]string)
+		if !ok {
+			return errors.New("WRONGTYPE Operation against a key holding the wrong kind of value")
+		}
+		if len(typedList) == 0 {
+			return nil
+		}
+		newItem := typedList[len(typedList)-1]
+		newList := typedList[:len(typedList)-1]
+		if len(newList) <= 0 {
+			delete(s.Data, key)
+		} else {
+			s.Data[key] = core.Item{Value: newList}
+		}
+		return newItem
+}
\ No newline at end of file